root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Basic searching #110

Merged
root merged 6 commits from 4-main-search-form into develop 2019-05-29 17:00:00 +00:00
Conversation 30 Commits 6 Files changed 9 +152 -17
root commented 2019-05-29 11:27:02 +00:00 (Migrated from dev.cryptec.at)

Related to #4

For now this implements a basic search using the in Django included text search features for postgres.

Related to #4 For now this implements a basic search using the in Django included text search features for postgres.
root commented 2019-05-29 11:27:02 +00:00 (Migrated from dev.cryptec.at)

changed milestone to %1

changed milestone to %1
root commented 2019-05-29 11:28:34 +00:00 (Migrated from dev.cryptec.at)

changed title from WIP: {-Resolve "Main search form"-} to WIP: {+Basic searching+}

changed title from **WIP: {-Resolve "Main search form"-}** to **WIP: {+Basic searching+}**
root commented 2019-05-29 11:28:34 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
root commented 2019-05-29 11:29:54 +00:00 (Migrated from dev.cryptec.at)

added 4 commits

  • e8fb1aa9 - Enable required postgres extensions for search and change from sqlite to postgres as default db
  • 425baabd - Add initial search filter to backend
  • d7d54a97 - Add debounced search input to frontend
  • b34006ec - Change ci to use postgresql

Compare with previous version

added 4 commits <ul><li>e8fb1aa9 - Enable required postgres extensions for search and change from sqlite to postgres as default db</li><li>425baabd - Add initial search filter to backend</li><li>d7d54a97 - Add debounced search input to frontend</li><li>b34006ec - Change ci to use postgresql</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=319&start_sha=0f2e81e4dc34d474aa63d083dcf0bcf53616f0aa)
root commented 2019-05-29 11:39:54 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

Compare with previous version

added 1 commit <ul><li>bd77644e - Include all filters</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=320&start_sha=b34006ec8cbf57c5e4f3f5ba30bb40b80e2f2105)
david commented 2019-05-29 11:55:34 +00:00 (Migrated from dev.cryptec.at)

Please change this to

DATABASE_URL=postgresql:///claypot

to default to socket authentication first.

Please change this to ``` DATABASE_URL=postgresql:///claypot ``` to default to socket authentication first.
david commented 2019-05-29 11:57:18 +00:00 (Migrated from dev.cryptec.at)

What purpose do these quotation marks serve?

What purpose do these quotation marks serve?
david commented 2019-05-29 11:57:58 +00:00 (Migrated from dev.cryptec.at)

Are you certain {} in this context does not result in a function returning undefined?

Are you certain `{}` in this context does not result in a function returning `undefined`?
david commented 2019-05-29 11:58:54 +00:00 (Migrated from dev.cryptec.at)

Why is a computed property named in an imperative style? Name it filters instead.

Why is a computed property named in an imperative style? Name it `filters` instead.
david commented 2019-05-29 11:59:53 +00:00 (Migrated from dev.cryptec.at)

Why are all of these keys quoted, when they don't have to be?

Why are all of these keys quoted, when they don't have to be?
root commented 2019-05-29 12:00:27 +00:00 (Migrated from dev.cryptec.at)

Screenshot_2019-05-29_at_13.59.32

Yes.

![Screenshot_2019-05-29_at_13.59.32](/uploads/3d97609c36dc2cb77110cf7afee30f18/Screenshot_2019-05-29_at_13.59.32.png) Yes.
david commented 2019-05-29 12:01:56 +00:00 (Migrated from dev.cryptec.at)

You tested the wrong thing. Try

const f = () => {}
typeof (f()) === 'undefined'
You tested the wrong thing. Try ```javascript const f = () => {} typeof (f()) === 'undefined' ```
root commented 2019-05-29 12:05:53 +00:00 (Migrated from dev.cryptec.at)

Just realized. Sorry.

Just realized. Sorry.
root commented 2019-05-29 12:09:12 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6#3c84dcdc6bbe3d7817c49dcdc327b926fea1808a_2_2)
root commented 2019-05-29 12:09:13 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6#69ab0e99ec276490dcc42f8ba201fea2ebc99455_38_38)
root commented 2019-05-29 12:09:13 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6#69ab0e99ec276490dcc42f8ba201fea2ebc99455_40_40)
root commented 2019-05-29 12:09:13 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6#69ab0e99ec276490dcc42f8ba201fea2ebc99455_44_44)
root commented 2019-05-29 12:09:13 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6#dc931edfc11b119be5f9837975ddf3cbc85299e2_8_8)
root commented 2019-05-29 12:09:13 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 45fd15db - Fix connection string, quotes and method naming

Compare with previous version

added 1 commit <ul><li>45fd15db - Fix connection string, quotes and method naming</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=321&start_sha=bd77644efd693521fb69b978b1779d21f222d3c6)
david commented 2019-05-29 12:10:49 +00:00 (Migrated from dev.cryptec.at)

resolved all discussions

resolved all discussions
david commented 2019-05-29 12:12:03 +00:00 (Migrated from dev.cryptec.at)

Does that work with 4 /'s? I have working systems with 3 /'s, but have never tried 4 of them.

Does that work with 4 `/`'s? I have working systems with 3 `/`'s, but have never tried 4 of them.
root commented 2019-05-29 12:13:07 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=322&start_sha=45fd15dbc0c37bef5f93d62c8e8caa3e1ecc3bea#3c84dcdc6bbe3d7817c49dcdc327b926fea1808a_2_2)
root commented 2019-05-29 12:13:08 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • e97c5163 - Fix connection string, quotes and method naming

Compare with previous version

added 1 commit <ul><li>e97c5163 - Fix connection string, quotes and method naming</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/30/diffs?diff_id=322&start_sha=45fd15dbc0c37bef5f93d62c8e8caa3e1ecc3bea)
root commented 2019-05-29 12:14:25 +00:00 (Migrated from dev.cryptec.at)

No, it doesn't. Should've tried after changing.

No, it doesn't. Should've tried after changing.
root commented 2019-05-29 12:14:27 +00:00 (Migrated from dev.cryptec.at)

resolved all discussions

resolved all discussions
david commented 2019-05-29 12:16:34 +00:00 (Migrated from dev.cryptec.at)

LGTM

LGTM
root commented 2019-05-29 16:59:18 +00:00 (Migrated from dev.cryptec.at)

Then I'll go ahead and merge that. Probably also time for a new release.

Then I'll go ahead and merge that. Probably also time for a new release.
root commented 2019-05-29 16:59:50 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2019-05-29 17:00:00 +00:00 (Migrated from dev.cryptec.at)

merged

merged
root commented 2019-05-29 17:00:00 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 364b858ed8

mentioned in commit 364b858ed8e70cf345fab8839e8c27b9e33c500a
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Public instance
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!110
No description provided.