root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Resolve "Prettier recipe list" #112

Merged
root merged 9 commits from 9-prettier-recipe-list into develop 2019-06-15 14:19:17 +00:00
Conversation 17 Commits 9 Files changed 17 +244 -33
root commented 2019-06-05 21:07:50 +00:00 (Migrated from dev.cryptec.at)

Closes #9

Closes #9
root commented 2019-06-05 21:07:50 +00:00 (Migrated from dev.cryptec.at)

changed milestone to %1

changed milestone to %1
root commented 2019-06-05 21:09:12 +00:00 (Migrated from dev.cryptec.at)

added 5 commits

  • 5c488356 - Add pagination to rest framework and disable html renderer in production
  • 4eeaae36 - Add navigation for paginated recipe list
  • 9fb115a9 - Add thumbnail field to image
  • 11093049 - Add thumbnail url to recipe list serializer
  • afc984f9 - Add thumbnail view in frontend

Compare with previous version

added 5 commits <ul><li>5c488356 - Add pagination to rest framework and disable html renderer in production</li><li>4eeaae36 - Add navigation for paginated recipe list</li><li>9fb115a9 - Add thumbnail field to image</li><li>11093049 - Add thumbnail url to recipe list serializer</li><li>afc984f9 - Add thumbnail view in frontend</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=326&start_sha=0683860a4993bdd461ef784db034d32928987c50)
root commented 2019-06-06 17:25:18 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • a0284188 - Add profile store module to allow saving of e.g. interface related settings,...

Compare with previous version

added 1 commit <ul><li>a0284188 - Add profile store module to allow saving of e.g. interface related settings,...</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=327&start_sha=afc984f9efb6f4949b7ac05eb4a630e363dc764f)
root commented 2019-06-06 17:39:09 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 1169f4fd - Add pagination and information if thumbnail is missing

Compare with previous version

added 1 commit <ul><li>1169f4fd - Add pagination and information if thumbnail is missing</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=328&start_sha=a0284188a12dea0ce21209efb62ac32070ecffa5)
root commented 2019-06-06 17:43:43 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 43f1f81c - Code formatting with black

Compare with previous version

added 1 commit <ul><li>43f1f81c - Code formatting with black</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=329&start_sha=1169f4fd64d13235fb26ed10499aea6902f7e95d)
root commented 2019-06-06 19:12:16 +00:00 (Migrated from dev.cryptec.at)

added 8 commits

  • 8641ea1d - 1 commit from branch develop
  • 59e06000 - Add thumbnail field to image
  • 8a23595d - Add thumbnail url to recipe list serializer
  • a6c8d574 - Add thumbnail view in frontend
  • 2f47717f - Add profile store module to allow saving of e.g. interface related settings,...
  • 1f28fb33 - Add pagination and information if thumbnail is missing
  • 84af718f - Code formatting with black
  • d4b5cf4e - Hide image gallery if no images are available

Compare with previous version

added 8 commits <ul><li>8641ea1d - 1 commit from branch <code>develop</code></li><li>59e06000 - Add thumbnail field to image</li><li>8a23595d - Add thumbnail url to recipe list serializer</li><li>a6c8d574 - Add thumbnail view in frontend</li><li>2f47717f - Add profile store module to allow saving of e.g. interface related settings,...</li><li>1f28fb33 - Add pagination and information if thumbnail is missing</li><li>84af718f - Code formatting with black</li><li>d4b5cf4e - Hide image gallery if no images are available</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=331&start_sha=43f1f81cdf66fb65910448eb21f6135d4d878034)
root commented 2019-06-06 19:20:19 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

Compare with previous version

added 1 commit <ul><li>96158a60 - Fix a few layout issues</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=332&start_sha=d4b5cf4e2a2ec2dc2482cdfdadd7e00eba3d4527)
root commented 2019-06-06 19:20:35 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2019-06-06 19:20:38 +00:00 (Migrated from dev.cryptec.at)

assigned to @david

assigned to @david
david commented 2019-06-06 20:05:30 +00:00 (Migrated from dev.cryptec.at)

There is nothing that makes sure this is always the same "first" image, because the list of images is not sorted. I suggest you make this at least

        image = obj.images.order_by("id").first()
There is nothing that makes sure this is always the same "first" image, because the list of images is not sorted. I suggest you make this at least ```suggestion:-0+0 image = obj.images.order_by("id").first() ```
david commented 2019-06-06 20:31:42 +00:00 (Migrated from dev.cryptec.at)

I think

  getHomeView: state => !!state.homeView

would be a little more obvious. I makes quite clear, that getHomeView can only be a boolean value. The former way of writing this has the user thinking about other data types as well.

I think ```suggestion:-0+0 getHomeView: state => !!state.homeView ``` would be a little more obvious. I makes quite clear, that `getHomeView` can only be a boolean value. The former way of writing this has the user thinking about other data types as well.
david commented 2019-06-06 20:33:07 +00:00 (Migrated from dev.cryptec.at)

Apart from my suggestions I have no further issues with these changes.

Apart from my suggestions I have no further issues with these changes.
root commented 2019-06-15 14:15:22 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=333&start_sha=96158a60def6790d1022c863880fb55b795952b7#3ea82e62b97410c71004c6608185a020146e3e19_8_8)
root commented 2019-06-15 14:15:23 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

Compare with previous version

added 1 commit <ul><li>74759cce - Apply suggested changes</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/32/diffs?diff_id=333&start_sha=96158a60def6790d1022c863880fb55b795952b7)
root commented 2019-06-15 14:19:05 +00:00 (Migrated from dev.cryptec.at)

resolved all discussions

resolved all discussions
root commented 2019-06-15 14:19:17 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 1b9f66c1c7

mentioned in commit 1b9f66c1c76ec9eea5c4acca365ecf61692dccbe
root commented 2019-06-15 14:19:17 +00:00 (Migrated from dev.cryptec.at)

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Public instance
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!112
No description provided.