Resolve "error on signup" #120

Merged
root merged 3 commits from 54-error-on-signup into master 2019-07-02 11:39:34 +00:00
root commented 2019-07-02 10:54:08 +00:00 (Migrated from dev.cryptec.at)

Closes #54

Closes #54
root commented 2019-07-02 11:16:51 +00:00 (Migrated from dev.cryptec.at)

added 2 commits

  • 04c19490 - Fix error handling on signup process and resend mail if link got invalidated
  • a2cdb9a3 - Add username for forgetful users to signup email

Compare with previous version

added 2 commits <ul><li>04c19490 - Fix error handling on signup process and resend mail if link got invalidated</li><li>a2cdb9a3 - Add username for forgetful users to signup email</li></ul> [Compare with previous version](/root/claypot/merge_requests/40/diffs?diff_id=350&start_sha=56655a807f49ab3cdf986a2f9a8ee71439ef2d52)
root commented 2019-07-02 11:19:52 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2019-07-02 11:19:57 +00:00 (Migrated from dev.cryptec.at)

assigned to @david

assigned to @david
david commented 2019-07-02 11:33:55 +00:00 (Migrated from dev.cryptec.at)
            return HttpResponse(_("Signup link is invalid. Did you copy the URL correctly?"))
```suggestion:-0+0 return HttpResponse(_("Signup link is invalid. Did you copy the URL correctly?")) ```
root commented 2019-07-02 11:34:33 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/root/claypot/merge_requests/40/diffs?diff_id=351&start_sha=a2cdb9a3c50358d7517518a772922addf4f260cf#e76764f12f1676f09c097353912c0d86d2a11c84_105_105)
root commented 2019-07-02 11:34:33 +00:00 (Migrated from dev.cryptec.at)

resolved all discussions

resolved all discussions
root commented 2019-07-02 11:34:34 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 4057fe89 - Apply suggestion to claypot/accounts/views.py

Compare with previous version

added 1 commit <ul><li>4057fe89 - Apply suggestion to claypot/accounts/views.py</li></ul> [Compare with previous version](/root/claypot/merge_requests/40/diffs?diff_id=351&start_sha=a2cdb9a3c50358d7517518a772922addf4f260cf)
david commented 2019-07-02 11:35:37 +00:00 (Migrated from dev.cryptec.at)

LGTM 🤷

LGTM :shrug:
david (Migrated from dev.cryptec.at) scheduled this pull request to auto merge when all checks succeed 2019-07-02 11:35:38 +00:00
root (Migrated from dev.cryptec.at) canceled auto merging this pull request when all checks succeed 2019-07-02 11:37:37 +00:00
root commented 2019-07-02 11:37:38 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • c51eba14 - Apply suggestion to claypot/accounts/views.py

Compare with previous version

added 1 commit <ul><li>c51eba14 - Apply suggestion to claypot/accounts/views.py</li></ul> [Compare with previous version](/root/claypot/merge_requests/40/diffs?diff_id=352&start_sha=4057fe89f5549cf88a5a0fa8c71aa6141b08b891)
root (Migrated from dev.cryptec.at) scheduled this pull request to auto merge when all checks succeed 2019-07-02 11:39:09 +00:00
root commented 2019-07-02 11:39:34 +00:00 (Migrated from dev.cryptec.at)

merged

merged
root commented 2019-07-02 11:39:34 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit c61567436b

mentioned in commit c61567436b5e01fb27ea8a86ffeb43cd9eefb7be
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!120
No description provided.