root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Resolve "Cleanup of recipe editing" #142

Merged
root merged 20 commits from 64-cleanup-of-recipe-editing into master 2020-01-21 15:33:32 +00:00
Conversation 16 Commits 20 Files changed 28 +1497 -1206
root commented 2019-12-25 17:31:38 +00:00 (Migrated from dev.cryptec.at)

Collection of cleanups in the recipe edit components

Issues affected:

Changes include:

  • Move drafts to a own component
  • Simplify disabling the recipe edit form on save
  • Use sync instead of local copies for more readability
  • Only use ingredient groups
  • Fix frontend saving/loading/error handling
  • Update tests
Collection of cleanups in the recipe edit components Issues affected: - Closes #64 - Closes #63 Changes include: - [x] Move drafts to a own component - [x] Simplify disabling the recipe edit form on save - [x] Use sync instead of local copies for more readability - [x] Only use ingredient groups - [x] Fix frontend saving/loading/error handling - [x] Update tests
root commented 2019-12-25 17:32:53 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
root commented 2019-12-25 17:33:31 +00:00 (Migrated from dev.cryptec.at)

added 5 commits

  • b36539ad - Use only one method to create a new default recipe
  • f7701365 - Move drafting of recipes to own component
  • a3fa7e93 - Scratch RecipeAdd and merge with RecipeEdit, load recipe in form and use...
  • 9195f31d - Fix image handling in recipe edit
  • a929e3b6 - Move helper functions to utils, simplify logic around ingredients

Compare with previous version

added 5 commits <ul><li>b36539ad - Use only one method to create a new default recipe</li><li>f7701365 - Move drafting of recipes to own component</li><li>a3fa7e93 - Scratch RecipeAdd and merge with RecipeEdit, load recipe in form and use...</li><li>9195f31d - Fix image handling in recipe edit</li><li>a929e3b6 - Move helper functions to utils, simplify logic around ingredients</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=470&start_sha=f397f5467ea06853ed687515149a9f69d3ef166c)
root commented 2019-12-25 17:34:04 +00:00 (Migrated from dev.cryptec.at)

assigned to @david

assigned to @david
root commented 2019-12-25 17:36:06 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
root commented 2019-12-29 21:40:20 +00:00 (Migrated from dev.cryptec.at)

added 8 commits

  • 4baaa57f - Remove RecipeIngredientGroupIngredient and migrate to RecipeIngredient
  • 8cc1717d - Move to new save logic for recipes in backend
  • 622e78ca - Setup frontend and backend for new saving logic
  • 90e36e8f - Squash ingredient-unifying migrations
  • 7b77f06e - Create new ingredients on normal saving instead of a separate requestt
  • a7f7966a - Move the recipe serializer to a model serializer
  • 0a7e9770 - Fix error handling on recipe save
  • b126947d - Fix backend tests, rename migrations

Compare with previous version

added 8 commits <ul><li>4baaa57f - Remove RecipeIngredientGroupIngredient and migrate to RecipeIngredient</li><li>8cc1717d - Move to new save logic for recipes in backend</li><li>622e78ca - Setup frontend and backend for new saving logic</li><li>90e36e8f - Squash ingredient-unifying migrations</li><li>7b77f06e - Create new ingredients on normal saving instead of a separate requestt</li><li>a7f7966a - Move the recipe serializer to a model serializer</li><li>0a7e9770 - Fix error handling on recipe save</li><li>b126947d - Fix backend tests, rename migrations</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=471&start_sha=a929e3b6961bde2ff448f9ba90022702ae90ae16)
root commented 2019-12-29 22:11:26 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 53acb4e1 - Remove pytest-black from testing

Compare with previous version

added 1 commit <ul><li>53acb4e1 - Remove pytest-black from testing</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=472&start_sha=b126947db61841cd80647a266e597fdf48a997f9)
root commented 2019-12-29 22:12:05 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 0813f251 - Remove pytest-black from testing

Compare with previous version

added 1 commit <ul><li>0813f251 - Remove pytest-black from testing</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=473&start_sha=53acb4e168e4ed05bb8a7731befece7320a64666)
root commented 2019-12-29 22:32:32 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
root commented 2019-12-30 12:54:42 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 05211c51 - Fix handling of non existent ids on ingredient save

Compare with previous version

added 1 commit <ul><li>05211c51 - Fix handling of non existent ids on ingredient save</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=474&start_sha=0813f2513ca17d52671a06af4cede65620b221f5)
root commented 2019-12-30 12:55:40 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2020-01-02 11:33:20 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 6d3eccc5 - Add tests for recipegroupingredient migration, filters, fix bug in the relation serializer

Compare with previous version

added 1 commit <ul><li>6d3eccc5 - Add tests for recipegroupingredient migration, filters, fix bug in the relation serializer</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=475&start_sha=05211c513b95252ab243b57b14909f58f712ef93)
root commented 2020-01-02 11:42:59 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • d5f7e501 - Migrate to ingredient groups only in fixtures

Compare with previous version

added 1 commit <ul><li>d5f7e501 - Migrate to ingredient groups only in fixtures</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=476&start_sha=6d3eccc5fad6c22fc37af921230d4b5b4c733b5f)
david commented 2020-01-10 18:50:02 +00:00 (Migrated from dev.cryptec.at)

Unfortunately this mounts up to a regression. Enter this key stroke sequence to reproduce the behaviour:

  • 0
  • ,
  • 1
  • <BACKSPACE>
Unfortunately this mounts up to a regression. Enter this key stroke sequence to reproduce the behaviour: - `0` - `,` - `1` - `<BACKSPACE>`
root commented 2020-01-21 15:30:40 +00:00 (Migrated from dev.cryptec.at)

added 3 commits

  • 3dd23806 - Fix regression where a Number ending with a '.' wasn't display as the literal string
  • 876643c8 - Save recipe instance directly after creating it, otherwise you can't add m2m relations
  • 7ce69f6e - Fix loading, saving and updating of drafts

Compare with previous version

added 3 commits <ul><li>3dd23806 - Fix regression where a Number ending with a &#39;.&#39; wasn&#39;t display as the literal string</li><li>876643c8 - Save recipe instance directly after creating it, otherwise you can&#39;t add m2m relations</li><li>7ce69f6e - Fix loading, saving and updating of drafts</li></ul> [Compare with previous version](/root/claypot/merge_requests/62/diffs?diff_id=477&start_sha=d5f7e501c375c1d8d670c1e7210fd8996969c97c)
root commented 2020-01-21 15:31:38 +00:00 (Migrated from dev.cryptec.at)

resolved all threads

resolved all threads
root (Migrated from dev.cryptec.at) scheduled this pull request to auto merge when all checks succeed 2020-01-21 15:32:48 +00:00
root commented 2020-01-21 15:33:32 +00:00 (Migrated from dev.cryptec.at)

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!142
No description provided.