root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Improvements to the search experience #151

Merged
root merged 11 commits from feature/search into master 2020-06-01 20:43:33 +00:00
Conversation 19 Commits 11 Files changed 12 +1634 -1489
root commented 2020-05-26 16:01:57 +00:00 (Migrated from dev.cryptec.at)

Related to #4

  • Scroll to top after page change
  • Store search text in the url
  • Ordering
Related to #4 - Scroll to top after page change - Store search text in the url - Ordering
root commented 2020-05-26 18:10:21 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • d8b09fbe - Add (recipe) search ordering to frontend and backend.

Compare with previous version

added 1 commit <ul><li>d8b09fbe - Add (recipe) search ordering to frontend and backend.</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=513&start_sha=c235dc9f304d8045d70709fcf297b2551a235204)
root commented 2020-05-26 18:10:53 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
root commented 2020-05-26 18:11:01 +00:00 (Migrated from dev.cryptec.at)

assigned to @david and unassigned @root

assigned to @david and unassigned @root
root commented 2020-05-26 18:15:42 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 46c5ae5b - Remove unused key from german translation

Compare with previous version

added 1 commit <ul><li>46c5ae5b - Remove unused key from german translation</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=514&start_sha=d8b09fbe2628aff397c7a88a8c1d5402fb21c026)
root commented 2020-05-26 18:21:41 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2020-05-26 18:26:15 +00:00 (Migrated from dev.cryptec.at)

marked as a Work In Progress

marked as a **Work In Progress**
david commented 2020-05-27 06:04:34 +00:00 (Migrated from dev.cryptec.at)

I like it so far. Have you considered adding a loading indicator to the search input?

I like it so far. Have you considered adding a loading indicator to the search input?
root commented 2020-05-27 16:47:34 +00:00 (Migrated from dev.cryptec.at)

I believe there is a loading indication. Would you prefer a spinner icon instead?

I believe there is a loading indication. Would you prefer a spinner icon instead?
root commented 2020-05-27 18:44:14 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 846c8698 - Remember the user's preferences for the extended search and hide it if not needed

Compare with previous version

added 1 commit <ul><li>846c8698 - Remember the user&#39;s preferences for the extended search and hide it if not needed</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=515&start_sha=46c5ae5b01902e6ec979058042bba569e7936f73)
root commented 2020-05-27 19:12:49 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 2161b24f - Add basic styling for the extended search

Compare with previous version

added 1 commit <ul><li>2161b24f - Add basic styling for the extended search</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=516&start_sha=846c8698669f03c4e15d6bd4515b476f3b089309)
root commented 2020-05-27 22:50:47 +00:00 (Migrated from dev.cryptec.at)

added 2 commits

  • d8b3eecb - Allow ordering recipes by popularity (star count)
  • bedc97ae - Always clear the extended options on toggle

Compare with previous version

added 2 commits <ul><li>d8b3eecb - Allow ordering recipes by popularity (star count)</li><li>bedc97ae - Always clear the extended options on toggle</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=517&start_sha=2161b24f449b5b786f9038046b96d9565d2c7ba4)
root commented 2020-05-28 20:06:58 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2020-05-28 20:10:46 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 21b3386a - Don't use python2-styled super()

Compare with previous version

added 1 commit <ul><li>21b3386a - Don&#39;t use python2-styled super()</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=519&start_sha=bedc97ae584479cde1c361bf0d1d89b1260f7b43)
root commented 2020-05-31 14:38:46 +00:00 (Migrated from dev.cryptec.at)

I thought about using the sync modifier for exchanging the state of the filter between the components. The debounce would need to be executed in the parent component instead of the search itself. Writing a wrapping component is imo a task for a different MR.

I thought about using the sync modifier for exchanging the state of the filter between the components. The debounce would need to be executed in the parent component instead of the search itself. Writing a wrapping component is imo a task for a different MR.
root commented 2020-05-31 14:40:17 +00:00 (Migrated from dev.cryptec.at)

@david Are you willing to merge this as is or are there still unresolved issues?

@david Are you willing to merge this as is or are there still unresolved issues?
root commented 2020-05-31 14:44:45 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 23b148e6 - Use form instead of div for `utils/SearchForm.vue`

Compare with previous version

added 1 commit <ul><li>23b148e6 - Use form instead of div for `utils/SearchForm.vue`</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=520&start_sha=21b3386a2c9a9037521b79340a1d3e5edb433784)
david commented 2020-06-01 20:10:51 +00:00 (Migrated from dev.cryptec.at)

added 12 commits

  • 5fbe09ce - 1 commit from branch master
  • 0ea24880 - Update frontend dependencies
  • 0813d502 - Scroll to the top after changing the page
  • fd590e95 - Store the search result on '/' in the url and scroll to top after page change.
  • f9629ef7 - Add (recipe) search ordering to frontend and backend.
  • 13f272e3 - Remove unused key from german translation
  • a840d570 - Remember the user's preferences for the extended search and hide it if not needed
  • b16e0ce4 - Add basic styling for the extended search
  • 521a5f22 - Allow ordering recipes by popularity (star count)
  • 84547403 - Always clear the extended options on toggle
  • 7a8a30fc - Don't use python2-styled super()
  • 2d01a985 - Use form instead of div for `utils/SearchForm.vue`

Compare with previous version

added 12 commits <ul><li>5fbe09ce - 1 commit from branch <code>master</code></li><li>0ea24880 - Update frontend dependencies</li><li>0813d502 - Scroll to the top after changing the page</li><li>fd590e95 - Store the search result on &#39;/&#39; in the url and scroll to top after page change.</li><li>f9629ef7 - Add (recipe) search ordering to frontend and backend.</li><li>13f272e3 - Remove unused key from german translation</li><li>a840d570 - Remember the user&#39;s preferences for the extended search and hide it if not needed</li><li>b16e0ce4 - Add basic styling for the extended search</li><li>521a5f22 - Allow ordering recipes by popularity (star count)</li><li>84547403 - Always clear the extended options on toggle</li><li>7a8a30fc - Don&#39;t use python2-styled super()</li><li>2d01a985 - Use form instead of div for `utils/SearchForm.vue`</li></ul> [Compare with previous version](/root/claypot/-/merge_requests/71/diffs?diff_id=521&start_sha=23b148e611d3fa714ed7fb2f20dba80357424aa3)
david commented 2020-06-01 20:43:29 +00:00 (Migrated from dev.cryptec.at)

resolved all threads

resolved all threads
david commented 2020-06-01 20:43:34 +00:00 (Migrated from dev.cryptec.at)

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!151
No description provided.