root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Feature/layout #90

Merged
root merged 4 commits from feature/layout into develop 2019-02-21 19:16:24 +00:00
Conversation 7 Commits 4 Files changed 4 +143 -103
root commented 2019-02-19 13:33:54 +00:00 (Migrated from dev.cryptec.at)

For now that means fixing the alignment of the current layout. Not a bunch of big changes around.

For now that means fixing the alignment of the current layout. Not a bunch of big changes around.
david commented 2019-02-19 15:18:11 +00:00 (Migrated from dev.cryptec.at)

Recipe detail, Desktop

image

Mostly fine, maybe move the author somewhere else. Maybe vertically aligned with the right side of the image and horizontally aligned with the star button.

Recipe detail, mobile

image

Maybe lower margin left and right of the photo to zero? Also there is no fixed navbar.

# Recipe detail, Desktop ![image](/uploads/29d1644319c37824b31397f009af055f/image.png) Mostly fine, maybe move the author somewhere else. Maybe vertically aligned with the right side of the image and horizontally aligned with the star button. # Recipe detail, mobile ![image](/uploads/d350d0f1cf30127b6e7bf8605ef0f787/image.png) Maybe lower margin left and right of the photo to zero? Also there is no fixed navbar.
root commented 2019-02-19 21:31:06 +00:00 (Migrated from dev.cryptec.at)

added 20 commits

  • 7f5aff3a...dea0526e - 16 commits from branch develop
  • 28d60146 - Styling for ingredient groups
  • 12556f40 - Addd single ingredients-group view and maximum width of layout
  • b55e591c - Fix buttons and alignment on RecipeEditForm and friends
  • ff6230ac - Move author to the top.

Compare with previous version

added 20 commits <ul><li>7f5aff3a...dea0526e - 16 commits from branch <code>develop</code></li><li>28d60146 - Styling for ingredient groups</li><li>12556f40 - Addd single ingredients-group view and maximum width of layout</li><li>b55e591c - Fix buttons and alignment on RecipeEditForm and friends</li><li>ff6230ac - Move author to the top.</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/10/diffs?diff_id=219&start_sha=7f5aff3a06d1ae22bccfa45cacc0be75aedb8133)
root commented 2019-02-20 18:46:03 +00:00 (Migrated from dev.cryptec.at)

I fixed the position of the author. We should merge this but not close the layout issue.

I fixed the position of the author. We should merge this but not close the layout issue.
root commented 2019-02-20 18:46:59 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2019-02-21 19:16:24 +00:00 (Migrated from dev.cryptec.at)

merged

merged
root commented 2019-02-21 19:16:24 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 1a71ce15ce

mentioned in commit 1a71ce15ce198d1b1cd9e513fb67840dab31a25b
root commented 2019-02-24 10:07:10 +00:00 (Migrated from dev.cryptec.at)

mentioned in issue #1

mentioned in issue #1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!90
No description provided.