root/claypot
Watch
1
0
Fork
You've already forked claypot
 0
Code Issues 15 Pull requests 1 Projects Releases Packages Wiki Activity

Feature/images #93

Merged
root merged 33 commits from feature/images into develop 2019-04-28 16:09:39 +00:00
Conversation 51 Commits 33 Files changed 33 +894 -25
root commented 2019-02-20 18:44:18 +00:00 (Migrated from dev.cryptec.at)

Fixes #20
Closes !98

current concerns:

  • Testing
  • Separation between apps is pretty loose, maybe the base urls.py should be better organized.
  • Frontend part (Component for upload)
  • Exif data should be removed on upload.
  • Meta information (e.g. a description on model)
Fixes #20 Closes !98 current concerns: * [x] Testing * [x] Separation between apps is pretty loose, maybe the base `urls.py` should be better organized. * [x] Frontend part (Component for upload) * [x] Exif data should be removed on upload. * [x] Meta information (e.g. a description on model)
root commented 2019-02-21 19:20:12 +00:00 (Migrated from dev.cryptec.at)

added 11 commits

  • 71bc9747...1a71ce15 - 5 commits from branch develop
  • ea4ecd43 - Added redis rq dependency
  • b2ce7e57 - Add initial app, viewsets and serializers for photos
  • 7693a714 - Add resizing for uploaded images
  • e5f39ecf - Fix colorspace and the fit of thumbnails, add media to .gitignore
  • 966d1bb8 - Fix urls in DEBUG mode and serve media files via django
  • 7b667192 - Fix migration, remove debug, add compose file references for worker and redis

Compare with previous version

added 11 commits <ul><li>71bc9747...1a71ce15 - 5 commits from branch <code>develop</code></li><li>ea4ecd43 - Added redis rq dependency</li><li>b2ce7e57 - Add initial app, viewsets and serializers for photos</li><li>7693a714 - Add resizing for uploaded images</li><li>e5f39ecf - Fix colorspace and the fit of thumbnails, add media to .gitignore</li><li>966d1bb8 - Fix urls in DEBUG mode and serve media files via django</li><li>7b667192 - Fix migration, remove debug, add compose file references for worker and redis</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=221&start_sha=71bc9747163c843b685b36525b5827ac86e49e85)
root commented 2019-02-22 02:48:05 +00:00 (Migrated from dev.cryptec.at)

added 2 commits

  • c732a75b - Add initial upload support
  • 486de111 - Add preview thumbnails and retry button if single uploads fail

Compare with previous version

added 2 commits <ul><li>c732a75b - Add initial upload support</li><li>486de111 - Add preview thumbnails and retry button if single uploads fail</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=222&start_sha=7b6671929c320bafcdba9e26f770cdeaadeb6638)
david commented 2019-02-23 00:26:35 +00:00 (Migrated from dev.cryptec.at)

This should return ImageRetrieveSerializer(instance=instance).data, right?

This should return `ImageRetrieveSerializer(instance=instance).data`, right?
david commented 2019-02-23 00:27:31 +00:00 (Migrated from dev.cryptec.at)

Use serializer.is_valid(raise_exception=True) for simplicity.

Use `serializer.is_valid(raise_exception=True)` for simplicity.
david commented 2019-02-23 00:28:06 +00:00 (Migrated from dev.cryptec.at)

Why call the app image everywhere - except here?

Why call the app `image` everywhere - except here?
root commented 2019-02-24 09:47:18 +00:00 (Migrated from dev.cryptec.at)

Do you mean the create? or the get_serializer_class?

Do you mean the `create`? or the `get_serializer_class`?
root commented 2019-02-24 10:01:56 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=228&start_sha=486de111d8b90fc9f9f89a28ea673414a48f153e#ec9d3a61c4116714e8c8294317efd533c8de469b_177_174)
root commented 2019-02-24 10:01:56 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=228&start_sha=486de111d8b90fc9f9f89a28ea673414a48f153e#ec9d3a61c4116714e8c8294317efd533c8de469b_179_174)
root commented 2019-02-24 10:01:56 +00:00 (Migrated from dev.cryptec.at)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=228&start_sha=486de111d8b90fc9f9f89a28ea673414a48f153e#6be5ed8f30a32f1fc4c65995f24c9044249ccd10_5_4)
root commented 2019-02-24 10:01:57 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • d4f45574 - Let serializer raise an exception, rename apps, create image folder if it doesn't exist

Compare with previous version

added 1 commit <ul><li>d4f45574 - Let serializer raise an exception, rename apps, create image folder if it doesn&#39;t exist</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=228&start_sha=486de111d8b90fc9f9f89a28ea673414a48f153e)
david commented 2019-02-24 10:03:29 +00:00 (Migrated from dev.cryptec.at)

I mean create. The note is always related to the line directly above the comment, Line 177 in this case.

I mean `create`. The note is always related to the line directly above the comment, Line 177 in this case.
root commented 2019-02-24 11:07:14 +00:00 (Migrated from dev.cryptec.at)

added 69 commits

  • d4f45574...531299cf - 59 commits from branch develop
  • afdc9e52 - Added redis rq dependency
  • dcf63dc4 - Add initial app, viewsets and serializers for photos
  • d34613d6 - Add resizing for uploaded images
  • 8f0bbca4 - Fix colorspace and the fit of thumbnails, add media to .gitignore
  • 9fb9bb65 - Fix urls in DEBUG mode and serve media files via django
  • b9bc245e - Fix migration, remove debug, add compose file references for worker and redis
  • 6390d6cb - Add initial upload support
  • ea7565af - Add preview thumbnails and retry button if single uploads fail
  • 68ced09e - Let serializer raise an exception, rename apps, create image folder if it doesn't exist
  • e59806b2 - Emit image id's of succesfull images

Compare with previous version

added 69 commits <ul><li>d4f45574...531299cf - 59 commits from branch <code>develop</code></li><li>afdc9e52 - Added redis rq dependency</li><li>dcf63dc4 - Add initial app, viewsets and serializers for photos</li><li>d34613d6 - Add resizing for uploaded images</li><li>8f0bbca4 - Fix colorspace and the fit of thumbnails, add media to .gitignore</li><li>9fb9bb65 - Fix urls in DEBUG mode and serve media files via django</li><li>b9bc245e - Fix migration, remove debug, add compose file references for worker and redis</li><li>6390d6cb - Add initial upload support</li><li>ea7565af - Add preview thumbnails and retry button if single uploads fail</li><li>68ced09e - Let serializer raise an exception, rename apps, create image folder if it doesn&#39;t exist</li><li>e59806b2 - Emit image id&#39;s of succesfull images</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=229&start_sha=d4f4557480868afac9a8d4450d9c0b2475b76ccc)
root commented 2019-02-24 11:08:13 +00:00 (Migrated from dev.cryptec.at)

@david Would you please take a look at the integration in the RecipeEditForm component?

@david Would you please take a look at the integration in the `RecipeEditForm` component?
root commented 2019-02-24 11:13:21 +00:00 (Migrated from dev.cryptec.at)

marked the checklist item Separation between apps is pretty loose, maybe the base urls.py should be better organized. as completed

marked the checklist item **Separation between apps is pretty loose, maybe the base `urls.py` should be better organized.** as completed
root commented 2019-02-24 11:13:25 +00:00 (Migrated from dev.cryptec.at)

marked the checklist item Frontend part (Component for upload) as completed

marked the checklist item **Frontend part (Component for upload)** as completed
david commented 2019-02-24 12:23:36 +00:00 (Migrated from dev.cryptec.at)

added 2 commits

  • d56028e7 - Fix formatting and sorting
  • 54999412 - Add saving of images

Compare with previous version

added 2 commits <ul><li>d56028e7 - Fix formatting and sorting</li><li>54999412 - Add saving of images</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=230&start_sha=e59806b228642e95bf2b7ffec0ade1573d4585d4)
david commented 2019-02-24 12:25:39 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 63952ac5 - Fix unit tests

Compare with previous version

added 1 commit <ul><li>63952ac5 - Fix unit tests</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=231&start_sha=5499941282eb7ad1bd48c4e53d9e9f93751415a7)
david commented 2019-02-24 12:26:42 +00:00 (Migrated from dev.cryptec.at)

@root Here you go.

@root Here you go.
david commented 2019-02-24 12:31:38 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • d19885a3 - Add persistence for media and images directory

Compare with previous version

added 1 commit <ul><li>d19885a3 - Add persistence for media and images directory</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=232&start_sha=63952ac59cd1b852768df5ebc56cf72d5d9f9da1)
root commented 2019-02-24 13:04:01 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 315a19e9 - Add tests for image upload and resizing

Compare with previous version

added 1 commit <ul><li>315a19e9 - Add tests for image upload and resizing</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=233&start_sha=d19885a3876d5a2a67e436a07316af54361da4a2)
root commented 2019-02-24 13:04:29 +00:00 (Migrated from dev.cryptec.at)

marked the checklist item Testing as completed

marked the checklist item **Testing** as completed
root commented 2019-02-24 13:06:21 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • e5472edd - Add requirements for image tests

Compare with previous version

added 1 commit <ul><li>e5472edd - Add requirements for image tests</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=234&start_sha=315a19e96b69c53bfc473f6770370f6c546f2c91)
root commented 2019-02-24 13:18:05 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 15d5147a - downgrade redis for testing

Compare with previous version

added 1 commit <ul><li>15d5147a - downgrade redis for testing</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=235&start_sha=e5472eddfbb1970c63ff4d2f4c08c5d1a842485f)
david commented 2019-02-24 14:14:15 +00:00 (Migrated from dev.cryptec.at)

mentioned in merge request !98

mentioned in merge request !98
david commented 2019-02-24 14:15:10 +00:00 (Migrated from dev.cryptec.at)

changed the description

changed the description
david commented 2019-02-24 14:15:10 +00:00 (Migrated from dev.cryptec.at)

changed milestone to %1

changed milestone to %1
david commented 2019-02-24 14:19:01 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit be3492a9d2

mentioned in commit be3492a9d2c69d47df5b3a1ad2d392a8af6aed9e
david commented 2019-02-24 14:24:42 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 72eff5e50eee9a13960cb3cc5435f2c287eb949f

mentioned in commit 72eff5e50eee9a13960cb3cc5435f2c287eb949f
david commented 2019-02-24 14:24:43 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 72eff5e5 - Revert "Remove dependency on !93"

Compare with previous version

added 1 commit <ul><li>72eff5e5 - Revert &quot;Remove dependency on !93&quot;</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=239&start_sha=15d5147a0c2458da8037381a56b36df95d97bfbf)
root commented 2019-02-24 20:52:29 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 8b5100ee - Add initial gallery components

Compare with previous version

added 1 commit <ul><li>8b5100ee - Add initial gallery components</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=240&start_sha=72eff5e50eee9a13960cb3cc5435f2c287eb949f)
david commented 2019-02-24 21:31:41 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 59f4a1eec6905d1022803afe6116fa323501371f

mentioned in commit 59f4a1eec6905d1022803afe6116fa323501371f
root commented 2019-02-24 21:31:42 +00:00 (Migrated from dev.cryptec.at)

added 26 commits

  • 8b5100ee...c3ac7850 - 6 commits from branch develop
  • 53e65b38 - Added redis rq dependency
  • 370f2586 - Add initial app, viewsets and serializers for photos
  • 854af3c3 - Add resizing for uploaded images
  • b652cd91 - Fix colorspace and the fit of thumbnails, add media to .gitignore
  • b9c92648 - Fix urls in DEBUG mode and serve media files via django
  • c6e0f6c3 - Fix migration, remove debug, add compose file references for worker and redis
  • 70d2d49a - Add initial upload support
  • 79d78d93 - Add preview thumbnails and retry button if single uploads fail
  • b2d46f38 - Let serializer raise an exception, rename apps, create image folder if it doesn't exist
  • 47c36e48 - Emit image id's of succesfull images
  • 90b16340 - Fix formatting and sorting
  • 8bd6bd8d - Add saving of images
  • 066b3574 - Fix unit tests
  • 756ce244 - Add persistence for media and images directory
  • c9d99bf4 - Add tests for image upload and resizing
  • 16718f91 - Add requirements for image tests
  • 9c12dbbd - downgrade redis for testing
  • 59f4a1ee - Revert "Remove dependency on !93"
  • afa4c633 - Add initial gallery components
  • 8df5b76d - Add permission for image upload

Compare with previous version

added 26 commits <ul><li>8b5100ee...c3ac7850 - 6 commits from branch <code>develop</code></li><li>53e65b38 - Added redis rq dependency</li><li>370f2586 - Add initial app, viewsets and serializers for photos</li><li>854af3c3 - Add resizing for uploaded images</li><li>b652cd91 - Fix colorspace and the fit of thumbnails, add media to .gitignore</li><li>b9c92648 - Fix urls in DEBUG mode and serve media files via django</li><li>c6e0f6c3 - Fix migration, remove debug, add compose file references for worker and redis</li><li>70d2d49a - Add initial upload support</li><li>79d78d93 - Add preview thumbnails and retry button if single uploads fail</li><li>b2d46f38 - Let serializer raise an exception, rename apps, create image folder if it doesn&#39;t exist</li><li>47c36e48 - Emit image id&#39;s of succesfull images</li><li>90b16340 - Fix formatting and sorting</li><li>8bd6bd8d - Add saving of images</li><li>066b3574 - Fix unit tests</li><li>756ce244 - Add persistence for media and images directory</li><li>c9d99bf4 - Add tests for image upload and resizing</li><li>16718f91 - Add requirements for image tests</li><li>9c12dbbd - downgrade redis for testing</li><li>59f4a1ee - Revert &quot;Remove dependency on !93&quot;</li><li>afa4c633 - Add initial gallery components</li><li>8df5b76d - Add permission for image upload</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=241&start_sha=8b5100ee2d128bc45640c92a3dd2be939640d006)
root commented 2019-02-24 21:33:31 +00:00 (Migrated from dev.cryptec.at)

@david Did you added the possibility to view uploaded photos in the edit view? Should we change the serializer or make a request for every image with the given id?

@david Did you added the possibility to view uploaded photos in the edit view? Should we change the serializer or make a request for every image with the given id?
root commented 2019-02-26 16:09:27 +00:00 (Migrated from dev.cryptec.at)

added 23 commits

  • afdc9e52 - Added redis rq dependency
  • dcf63dc4 - Add initial app, viewsets and serializers for photos
  • d34613d6 - Add resizing for uploaded images
  • 8f0bbca4 - Fix colorspace and the fit of thumbnails, add media to .gitignore
  • 9fb9bb65 - Fix urls in DEBUG mode and serve media files via django
  • b9bc245e - Fix migration, remove debug, add compose file references for worker and redis
  • 6390d6cb - Add initial upload support
  • ea7565af - Add preview thumbnails and retry button if single uploads fail
  • 68ced09e - Let serializer raise an exception, rename apps, create image folder if it doesn't exist
  • e59806b2 - Emit image id's of succesfull images
  • d56028e7 - Fix formatting and sorting
  • 54999412 - Add saving of images
  • 63952ac5 - Fix unit tests
  • d19885a3 - Add persistence for media and images directory
  • 315a19e9 - Add tests for image upload and resizing
  • e5472edd - Add requirements for image tests
  • 15d5147a - downgrade redis for testing
  • 72eff5e5 - Revert "Remove dependency on !93"
  • 8b5100ee - Add initial gallery components
  • fdcd9ca0 - Use ImageSerializers on recipe.
  • e2809a9f - Complete gallery and image frame setup
  • dfca1e78 - Add gallery to recipe detail pagei
  • 84f839bf - Add permission for image upload

Compare with previous version

added 23 commits <ul><li>afdc9e52 - Added redis rq dependency</li><li>dcf63dc4 - Add initial app, viewsets and serializers for photos</li><li>d34613d6 - Add resizing for uploaded images</li><li>8f0bbca4 - Fix colorspace and the fit of thumbnails, add media to .gitignore</li><li>9fb9bb65 - Fix urls in DEBUG mode and serve media files via django</li><li>b9bc245e - Fix migration, remove debug, add compose file references for worker and redis</li><li>6390d6cb - Add initial upload support</li><li>ea7565af - Add preview thumbnails and retry button if single uploads fail</li><li>68ced09e - Let serializer raise an exception, rename apps, create image folder if it doesn&#39;t exist</li><li>e59806b2 - Emit image id&#39;s of succesfull images</li><li>d56028e7 - Fix formatting and sorting</li><li>54999412 - Add saving of images</li><li>63952ac5 - Fix unit tests</li><li>d19885a3 - Add persistence for media and images directory</li><li>315a19e9 - Add tests for image upload and resizing</li><li>e5472edd - Add requirements for image tests</li><li>15d5147a - downgrade redis for testing</li><li>72eff5e5 - Revert &quot;Remove dependency on !93&quot;</li><li>8b5100ee - Add initial gallery components</li><li>fdcd9ca0 - Use ImageSerializers on recipe.</li><li>e2809a9f - Complete gallery and image frame setup</li><li>dfca1e78 - Add gallery to recipe detail pagei</li><li>84f839bf - Add permission for image upload</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=242&start_sha=8df5b76d1ce447cc1729f2b6e4057697b765b83d)
root commented 2019-02-26 16:12:50 +00:00 (Migrated from dev.cryptec.at)

Okay. Well I screwed up one of the rebases. 🙈
Currently saving of recipes is broken due to the change in the serializer. Not sure how you want to handle that. Use a different serializer for saving?

~~Okay. Well I screwed up one of the rebases.~~ :see\_no\_evil: Currently saving of recipes is broken due to the change in the serializer. Not sure how you want to handle that. Use a different serializer for saving?
david commented 2019-02-26 16:24:08 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 1fad722f12

mentioned in commit 1fad722f12636de0682a30f133e267d046756254
root commented 2019-02-26 16:24:09 +00:00 (Migrated from dev.cryptec.at)

added 29 commits

  • 84f839bf...c3ac7850 - 6 commits from branch develop
  • 654101d6 - Added redis rq dependency
  • 807a9adf - Add initial app, viewsets and serializers for photos
  • f38789e8 - Add resizing for uploaded images
  • 1f8e56fb - Fix colorspace and the fit of thumbnails, add media to .gitignore
  • c7b24cdd - Fix urls in DEBUG mode and serve media files via django
  • 9e474763 - Fix migration, remove debug, add compose file references for worker and redis
  • 5aff2ff1 - Add initial upload support
  • 70eb2957 - Add preview thumbnails and retry button if single uploads fail
  • b633ac20 - Let serializer raise an exception, rename apps, create image folder if it doesn't exist
  • d9464654 - Emit image id's of succesfull images
  • 9e8ed9c7 - Fix formatting and sorting
  • a5a08dd1 - Add saving of images
  • 89a8e464 - Fix unit tests
  • db8f1de1 - Add persistence for media and images directory
  • 71d4faa4 - Add tests for image upload and resizing
  • 3bfff0ff - Add requirements for image tests
  • fa41c6ec - downgrade redis for testing
  • 1fad722f - Revert "Remove dependency on !93"
  • 5edd9b03 - Add initial gallery components
  • 951d6150 - Use ImageSerializers on recipe.
  • a4e2c6d8 - Complete gallery and image frame setup
  • f78f7343 - Add gallery to recipe detail pagei
  • 46cc9438 - Add permission for image upload

Compare with previous version

added 29 commits <ul><li>84f839bf...c3ac7850 - 6 commits from branch <code>develop</code></li><li>654101d6 - Added redis rq dependency</li><li>807a9adf - Add initial app, viewsets and serializers for photos</li><li>f38789e8 - Add resizing for uploaded images</li><li>1f8e56fb - Fix colorspace and the fit of thumbnails, add media to .gitignore</li><li>c7b24cdd - Fix urls in DEBUG mode and serve media files via django</li><li>9e474763 - Fix migration, remove debug, add compose file references for worker and redis</li><li>5aff2ff1 - Add initial upload support</li><li>70eb2957 - Add preview thumbnails and retry button if single uploads fail</li><li>b633ac20 - Let serializer raise an exception, rename apps, create image folder if it doesn&#39;t exist</li><li>d9464654 - Emit image id&#39;s of succesfull images</li><li>9e8ed9c7 - Fix formatting and sorting</li><li>a5a08dd1 - Add saving of images</li><li>89a8e464 - Fix unit tests</li><li>db8f1de1 - Add persistence for media and images directory</li><li>71d4faa4 - Add tests for image upload and resizing</li><li>3bfff0ff - Add requirements for image tests</li><li>fa41c6ec - downgrade redis for testing</li><li>1fad722f - Revert &quot;Remove dependency on !93&quot;</li><li>5edd9b03 - Add initial gallery components</li><li>951d6150 - Use ImageSerializers on recipe.</li><li>a4e2c6d8 - Complete gallery and image frame setup</li><li>f78f7343 - Add gallery to recipe detail pagei</li><li>46cc9438 - Add permission for image upload</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=243&start_sha=84f839bfd0e470a56dff6b5797755f525097d78e)
root commented 2019-03-24 16:48:04 +00:00 (Migrated from dev.cryptec.at)

added 3 commits

  • dbd7de85 - Added image field to serializers
  • 1da2aa71 - Added persistent image view and upload in frontend
  • d53d8dcd - Remove image in frontend by clicking on them

Compare with previous version

added 3 commits <ul><li>dbd7de85 - Added image field to serializers</li><li>1da2aa71 - Added persistent image view and upload in frontend</li><li>d53d8dcd - Remove image in frontend by clicking on them</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=244&start_sha=46cc94384031bc06a0c1ab5817891595e8d79900)
root commented 2019-03-24 17:38:37 +00:00 (Migrated from dev.cryptec.at)

added 2 commits

  • 150b01f5 - Fix removal of images in backend
  • e0a604c6 - Simplify saving of images on a recipe

Compare with previous version

added 2 commits <ul><li>150b01f5 - Fix removal of images in backend</li><li>e0a604c6 - Simplify saving of images on a recipe</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=245&start_sha=d53d8dcda75506009a05cfdfbedc25a61182b2cb)
root commented 2019-03-24 17:51:09 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • f6a9834e - Fit images with real delete button and remove debug

Compare with previous version

added 1 commit <ul><li>f6a9834e - Fit images with real delete button and remove debug</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=246&start_sha=e0a604c68cb9f50fc9e27f1d96ed1d3fa0886ee8)
root commented 2019-03-24 17:51:48 +00:00 (Migrated from dev.cryptec.at)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
root commented 2019-03-24 17:53:01 +00:00 (Migrated from dev.cryptec.at)

@david Are you willing to have a look at this mess?
Propably somethings missing. But that should'nt be vital for the mission. 😃

@david Are you willing to have a look at this mess? Propably somethings missing. But that should'nt be vital for the mission. :smiley:
root commented 2019-03-24 19:33:34 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 15b085c7 - Linting and whitespace fixes in RecipeDetail view

Compare with previous version

added 1 commit <ul><li>15b085c7 - Linting and whitespace fixes in RecipeDetail view</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=247&start_sha=f6a9834e514e6ba6d8f769ac2baf7626c2b3d75d)
root commented 2019-03-24 19:48:30 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

Compare with previous version

added 1 commit <ul><li>b7d81c27 - More formatting issues</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=248&start_sha=15b085c779818cb00cd11c75670e5d6647c9d054)
root commented 2019-03-24 19:50:36 +00:00 (Migrated from dev.cryptec.at)

marked the checklist item Exif data should be removed on upload. as completed

marked the checklist item **Exif data should be removed on upload.** as completed
root commented 2019-03-24 19:59:00 +00:00 (Migrated from dev.cryptec.at)

marked the checklist item Meta information (e.g. a description on model) as completed

marked the checklist item **Meta information (e.g. a description on model)** as completed
root commented 2019-03-24 19:59:31 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 6e6a9b17 - Added missing translations for image upload

Compare with previous version

added 1 commit <ul><li>6e6a9b17 - Added missing translations for image upload</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=249&start_sha=b7d81c27965e9d29f5996da634ee4544af6e7562)
root commented 2019-04-28 14:07:28 +00:00 (Migrated from dev.cryptec.at)

added 1 commit

  • 1d0cd9cb - Add extra serializer for the retrieval of Recipes.

Compare with previous version

added 1 commit <ul><li>1d0cd9cb - Add extra serializer for the retrieval of Recipes.</li></ul> [Compare with previous version](https://dev.cryptec.at/root/claypot/merge_requests/13/diffs?diff_id=278&start_sha=6e6a9b1761d6d23d6caf28e470e18c13d3489d0b)
root commented 2019-04-28 14:26:19 +00:00 (Migrated from dev.cryptec.at)

resolved all discussions

resolved all discussions
david commented 2019-04-28 16:09:39 +00:00 (Migrated from dev.cryptec.at)

mentioned in commit 832bbdc9b7

mentioned in commit 832bbdc9b7c233f88b1b41d5c366bbacf6001b90
david commented 2019-04-28 16:09:39 +00:00 (Migrated from dev.cryptec.at)

merged

merged
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
Doing

   
maybe
This we might want to add

  
next

   
sentry
Created by Sentry

  
To Do
No labels
bug
Doing
maybe
next
sentry
To Do
Milestone
Clear milestone
No items
No milestone
Public instance
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
root/claypot!93
No description provided.